Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Accessibility) Ensures every ARIA input field has an accessible name error on range controls popover #135266

Closed
bhavyarm opened this issue Jun 27, 2022 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Accessibility Project:Controls Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@bhavyarm
Copy link
Contributor

Kibana version: main

Browser version: chrome latest

Browser OS version: os x

Original install method (e.g. download page, yum, from source, etc.): from dev

Describe the bug: Range controls pop-over has a11y error for "Ensures every ARIA input field has an accessible name" and fails the test I am trying to add in #135085

Dashboard controls a11y tests
       Dashboard with options and range control panel popovers:

      Error: a11y report:
 
 VIOLATION
   [aria-input-field-name]: Ensures every ARIA input field has an accessible name
     Impact: serious
     Help: https://dequeuniversity.com/rules/axe/4.0/aria-input-field-name?application=axeAPI
     Elements:
       - <div class="euiRangeThumb euiRangeThumb--hasTicks" role="slider" aria-valuemin="101" aria-valuemax="1200" aria-valuenow="101" aria-disabled="false" tabindex="0" style="left: 0%;"></div>
       - <div class="euiRangeThumb euiRangeThumb--hasTicks" role="slider" aria-valuemin="101" aria-valuemax="1200" aria-valuenow="1200" aria-disabled="false" tabindex="0" style="left: 97.3109%;"></div>
       at AccessibilityService.assertValidAxeReport (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/accessibility/services/a11y/a11y.ts:76:13)
       at AccessibilityService.testAppSnapshot (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/accessibility/services/a11y/a11y.ts:49:10)
       at runMicrotasks (<anonymous>)
       at processTicksAndRejections (node:internal/process/task_queues:96:5)
       at Context.<anonymous> (test/accessibility/apps/dashboard_controls.ts:90:7)
       at Object.apply (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
 
 

Screen Shot 2022-06-27 at 5 28 35 PM

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:Controls labels Jun 27, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@bhavyarm bhavyarm changed the title Ensures every ARIA input field has an accessible name error on range controls Ensures every ARIA input field has an accessible name error on range controls popover Jun 27, 2022
@Heenawter Heenawter added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jun 27, 2022
@Heenawter Heenawter self-assigned this Jun 28, 2022
@Heenawter Heenawter changed the title Ensures every ARIA input field has an accessible name error on range controls popover (Accessibility) Ensures every ARIA input field has an accessible name error on range controls popover Jun 28, 2022
@Heenawter
Copy link
Contributor

Closing in favour of #135466 because there are other related issues with the range slider component that are better handled all together :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Accessibility Project:Controls Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

3 participants