Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Invalid state of alert flyout on initialization #134585

Closed
Tracked by #170754
ghudgins opened this issue Jun 16, 2022 · 4 comments
Closed
Tracked by #170754

[Discover] Invalid state of alert flyout on initialization #134585

ghudgins opened this issue Jun 16, 2022 · 4 comments
Labels
Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. usability

Comments

@ghudgins
Copy link

ghudgins commented Jun 16, 2022

Kibana version: 8.3

Elasticsearch version: 8.3

Server OS version: Linux / Elastic Cloud

Browser version: Chromium Edge v100

Browser OS version: OSX

Original install method (e.g. download page, yum, from source, etc.): Elastic Cloud

Describe the bug:
Invalid state when entering alert flyout which causes a subtle negative experience without the user having done anything 'wrong'

Steps to reproduce:

  1. In discover, enter a search term "orphaned pod"
  2. Deciding this is a good alert, click Alerts -> "Create search threshold rule"

Result: Red error state around the name

Expected behavior:

  • If name is omitted, error state on name field shouldn't show until the user attempts to submit
  • Alternative: default name could resolve this too {search term} threshold alert like orphaned pod threshold alert in the above example

Screenshots (if relevant):
Initial screen state:
image

@ghudgins ghudgins added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application usability impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jun 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Jun 17, 2022

  • Alternative: default name could resolve this too {search term} threshold alert like orphaned pod threshold alert in the above example

this is what we can do in Discover, since validation of the form is I think domain of @elastic/response-ops . However due to the potential complexity of our query and filters, I'd suggest something like:

New threshold alert rule

@kertal
Copy link
Member

kertal commented Jun 24, 2022

removing the bug label since it's not a technical bug

@kertal kertal removed the bug Fixes for quality problems that affect the customer experience label Jun 24, 2022
@davismcphee davismcphee added the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 8, 2023
@kertal
Copy link
Member

kertal commented Nov 27, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. usability
Projects
None yet
Development

No branches or pull requests

4 participants