Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Action Connectors] make ibm and service now svg icons bigger #132591

Open
mgiota opened this issue May 20, 2022 · 1 comment
Open

[Action Connectors] make ibm and service now svg icons bigger #132591

mgiota opened this issue May 20, 2022 · 1 comment
Labels
Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mgiota
Copy link
Contributor

mgiota commented May 20, 2022 •
edited
Loading

📝 Summary

As part of this PR we spotted some issues with a few svg icons regarding Actions Connectors. There are a few icons that appear to be smaller than others. These icons look smaller in following places:

  • Observability Rule Details page
  • Wherever Edit Rule Flyout appears (o11y Rule pages, Rules and connectors and respective o11y apps from Alerts and Rules header menu)

O11y rule pages

Screenshot 2022-05-20 at 11 20 06

Edit Rule Flyout

Screenshot 2022-05-20 at 09 48 33

Here's the list of icons I identified that need to be fixed:

  • IBM resilient
  • Service Now

Note: Above screenshot which shows the list of action connectors looks fine in the Rule flyout. I just tuned it a bit to be able to identify the small logos.

Acceptance criteria

  • Provide a new svg for IBM
  • Provide a new svg for Service Now
  • Provide a new svg for any other icon you think might needs to be tuned. No need to provide any new svg for xmatters, since it is already fixed in this PR

cc @katrin-freihofner @fkanout @gmmorris
@botelastic botelastic bot added the needs-team Issues missing a team label label May 20, 2022
@mgiota mgiota added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label May 20, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label May 20, 2022
@mgiota mgiota mentioned this issue May 20, 2022
Merged
@mgiota mgiota changed the title [Action Connectors] update svg icons [Action Connectors] update ibm and service now svg icons May 20, 2022
@mgiota mgiota added the v8.3.0 label May 20, 2022
@mgiota mgiota changed the title [Action Connectors] update ibm and service now svg icons [Action Connectors] make ibm and service now svg icons bigger May 20, 2022
@emma-raffenne emma-raffenne added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Jun 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@emma-raffenne emma-raffenne removed the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Jun 21, 2022
@cnasikas cnasikas added Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mgiota @cnasikas @elasticmachine @emma-raffenne