-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TagClient
available to other plugins on server side
#130748
Comments
Pinging @elastic/kibana-core (Team:Core) |
Not exactly. we're exposing the soTagging feature via a request handler context too, e,g |
Looking at the code, exposing the However, the tagAssignmentService (which allows to assign/unassign tags to saved objects) is more problematic: as we need to make sure that the user performing the operation is allowed to update the target object(s), we are performing an authz check against the assigned types, using We could lift this authz check when creating the assignmentService from outside of a request handler, but tbh I don't really like this option very much... @jen-huang what exactly do you need to perform via the SO tagging APIs? Are you only going to create tags, or do you also need to assign them to existing objects? |
We will need to create tags and assign them to objects immediately after the objects are created.
Is it possible to instantiate an internal/system user version of a request object that Fleet can pass to tagAssignmentService? Similar to |
Describe the feature:
Expose
savedObjectTagging
client to other plugins for server-side consumption, currently it only exports an UI interface.Describe a specific use case for the feature:
Fleet needs this in order to add tags to Kibana assets that are installed and managed by Fleet: #123904.
When Fleet installs these assets, there is already an internally-scoped saved object client set up that is used:
kibana/x-pack/plugins/fleet/server/plugin.ts
Lines 421 to 424 in 0082e0c
So it would be great to be able to pass the same client to instantiate a
TagClient
.The text was updated successfully, but these errors were encountered: