Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Timeline Templates] Threshold Rule Investigate in Timeline action doesn't use Template Columns #129966

Closed
spong opened this issue Apr 12, 2022 · 3 comments · Fixed by #137233
Labels
bug Fixes for quality problems that affect the customer experience Feature:Threshold Rule Security Solution Threshold rule type Feature:Timeline Security Solution Timeline feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team

Comments

@spong
Copy link
Member

spong commented Apr 12, 2022

Originally discovered in 8.1.2 and raised from the discuss forums, it was noticed that when using the Investigate in Timeline action on a Threshold Rule Alert, the columns from the Timeline Template would not be copied over, e.g.

Upon reviewing the source of this action, there is special logic if the alert was created by a Threshold Rule, and it looks as if the template columns are not provided to the creatTimeline() call when duplicating from the template, and so the default columns are used instead.

timeline: {
...timelineDefaults,
description: `_id: ${alertDoc._id}`,
filters: allFilters,
dataProviders: templateValues.dataProviders ?? dataProviders,
id: TimelineId.active,
indexNames,
dateRange: {
start: thresholdFrom,
end: thresholdTo,
},
eventType: 'all',
kqlQuery: {
filterQuery: {
kuery: {
kind: language,
expression: templateValues.query ?? query,
},
serializedQuery: templateValues.query ?? query,
},
},
},

Note: The see this issue for the KQLSyntaxError seen in the above screenshot #129958

@spong spong added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Timeline Security Solution Timeline feature Feature:Threshold Rule Security Solution Threshold rule type Team:Threat Hunting:Investigations Security Solution Investigations Team labels Apr 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@spong
Copy link
Member Author

spong commented Apr 12, 2022

If fix is straightforward as it appears (adding columns: templateValues.columns), please backport as far as possible as there are users currently experiencing this issue -- thanks!

@michaelolo24 michaelolo24 added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed triage_needed labels Apr 27, 2022
@michaelolo24
Copy link
Contributor

Thanks @spong - we have tech debt work in progress around investigate in timeline. Should hopefully be able to help resolve much of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Threshold Rule Security Solution Threshold rule type Feature:Timeline Security Solution Timeline feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team
Projects
None yet
3 participants