Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit full screen button hides in FF when you mouse over it #12987

Closed
trevan opened this issue Jul 19, 2017 · 2 comments
Closed

Exit full screen button hides in FF when you mouse over it #12987

trevan opened this issue Jul 19, 2017 · 2 comments
Assignees
@stacey-gammon
Labels
bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@trevan
Copy link
Contributor

trevan commented Jul 19, 2017

In Firefox, the exit full screen button at the bottom hides when you mouse over it. In chrome, it stays open when you mouse over it.

Firefox:
firefox-exit-fullscreen

Chrome:
chrome-exit-fullscreen
@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. bug Fixes for quality problems that affect the customer experience :Sharing labels Jul 19, 2017
@cjcenizal
Copy link
Contributor

CC @stacey-gammon @snide

@stacey-gammon
Copy link
Contributor

I believe this is due to https://stackoverflow.com/questions/41210684/when-hovering-over-a-child-element-in-firefox --- children of buttons won't capture the hover event in firefox. Looks like I can fix it by changing the button to a div.

@stacey-gammon stacey-gammon self-assigned this Jul 20, 2017
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Jul 20, 2017
@stacey-gammon
Children of buttons won't capture hover events in firefox
c0a55f9 
Fixes elastic#12987
@stacey-gammon stacey-gammon mentioned this issue Jul 20, 2017
Merged
stacey-gammon added a commit that referenced this issue Jul 24, 2017
@stacey-gammon
Children of buttons won't capture hover events in firefox (#13015)
2f23303 
* Children of buttons won't capture hover events in firefox

Fixes #12987

* Make full screen div accessible

* Remove nested aria labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stacey-gammon stacey-gammon

Labels
bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cjcenizal @trevan @stacey-gammon