Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Show top modal is shown even after open the timeline from bottom #128350

Closed
ghost opened this issue Mar 23, 2022 · 5 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0

Comments

@ghost
Copy link

ghost commented Mar 23, 2022

Describe the bug
Show top modal is shown even after open the timeline from bottom

Build Details:

Version: 8.2.0 SNAPSHOT
Commit:9fa9ff2d72381525b12323a4b0bb9a4e5b6592c0
Build:51286

preconditions

  1. Alert should be generated

Steps to Reproduce

  1. Navigate to alerts page under security
  2. Open the alert flyout of generated alert
  3. Click on more actions icon of any field then click on "show top modal"
  4. Now click on timeline from bottom banner
  5. Observe that show top modal is still shown even after open the timeline from bottom

Actual Result
Show top modal is still shown even after open the timeline from bottom

Expected Result
Show top modal should not be shown after open the timeline from bottom

Screen-Shot

show.top.madal.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.2.0 labels Mar 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost assigned ghost and MadameSheema and unassigned ghost Mar 23, 2022
@MadameSheema MadameSheema added Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team labels Mar 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@michaelolo24
Copy link
Contributor

Hoping to solve these issues with some changes from the EUI side: elastic/eui#5781 (will hold off on this till that is decided on)

@michaelolo24 michaelolo24 added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v8.3.0 and removed triage_needed v8.2.0 labels Apr 12, 2022
@michaelolo24 michaelolo24 added v8.6.0 and removed v8.5.0 labels Oct 6, 2022
@michaelolo24
Copy link
Contributor

Potential fix: elastic/eui#5781 (comment)

@PhilippeOberti
Copy link
Contributor

closing as over the last couple of years the code has changed quite a bit:

  • the alert details flyout has been replaced by the expandable flyout
  • the timeline has seen a massive UI change and is not displayed in a modal

The issue is not reproducible anymore, as can be seen in the following video

Screen.Recording.2024-07-22.at.4.23.47.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0
Projects
None yet
Development

No branches or pull requests

5 participants