Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVB: VisEditor component propTypes don't match the properties being passed #12762

Closed
simianhacker opened this issue Jul 11, 2017 · 1 comment · Fixed by #12804
Closed

TSVB: VisEditor component propTypes don't match the properties being passed #12762

simianhacker opened this issue Jul 11, 2017 · 1 comment · Fixed by #12804
Assignees
@thomasneirynck
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@simianhacker
Copy link
Member

Looks like the signature of properties for the VisEditor component have changed and no longer match whats being passed in.

https://github.com/elastic/kibana/blob/master/src/core_plugins/metrics/public/components/vis_editor.js#L82-L92

doesn't match

https://github.com/elastic/kibana/blob/master/src/core_plugins/metrics/public/kbn_vis_types/editor_controller.js#L25
@simianhacker simianhacker added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) blocker bug Fixes for quality problems that affect the customer experience and removed blocker labels Jul 11, 2017
@thomasneirynck
Copy link
Contributor

Somewhat related, there's a similar stale declaration in the React editor_controller. The resize method should be removed as well.

@thomasneirynck thomasneirynck self-assigned this Jul 11, 2017
@thomasneirynck thomasneirynck mentioned this issue Jul 12, 2017
Closed
simianhacker added a commit to simianhacker/kibana that referenced this issue Jul 12, 2017
@simianhacker
Fixes elastic#12762 - Fixing propTypes to match props being passed
4f6bebd
@simianhacker simianhacker mentioned this issue Jul 12, 2017
Merged
simianhacker added a commit that referenced this issue Jul 12, 2017
@simianhacker
Fix TSVB Visualizations to honor darkTheme (#12804)
5e6a097 
* Fixes #12802 - Fix TSVB Visualizations to honor darkTheme

* Sometimes appState doesn't exist

* Fixes #12762 - Fixing propTypes to match props being passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasneirynck thomasneirynck

Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TSVB Visualizations to honor darkTheme simianhacker/kibana
2 participants
@simianhacker @thomasneirynck