Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify naming. currently used as config, settings, ui settings, advanced settings #126991

Open
TinaHeiligers opened this issue Mar 6, 2022 · 4 comments
Open

unify naming. currently used as config, settings, ui settings, advanced settings #126991

TinaHeiligers opened this issue Mar 6, 2022 · 4 comments
Labels
documentation enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated old Used to help sort old issues on GH Projects which don't support the Created search term. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Mar 6, 2022 •
edited
Loading

uiSettings are currently referred to as config, settings, ui settings and advanced settings that leads to confusion about what uiSettings are.

We should clarify naming and ensure the documentation uses the appropriate term.
@TinaHeiligers TinaHeiligers mentioned this issue Mar 6, 2022
Open
21 tasks
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 6, 2022
@TinaHeiligers TinaHeiligers added documentation enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Mar 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 6, 2022
@pgayvallet
Copy link
Contributor

config should ihmo only be used to refer to the saved object (type) that is holding the ui/advanced/settings.

Regarding settings vs ui settings vs advanced settings I agree that we should stick to one naming only. @TinaHeiligers given the changes we foresee regarding user settings, which one do you think would make the most sense to use for the 'current' uiSettings?

@majagrubic majagrubic added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Feb 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@TinaHeiligers
Copy link
Contributor Author

changes we foresee regarding user settings, which one do you think would make the most sense to use for the 'current' uiSettings

A little late to respond here but these are my thoughts:

  • ATM, our 'current' settings are a mixed bag containing settings that drive both functionality (these change the behavior of something) and UI (change the observed visual manifestation of something). As such, a more general term would probably be best, like plain old 'settings'
  • We should then really think about splitting these general 'settings' into distinct setting-types: those that change the behavior of some functionality and those that change the visual appearance.

@petrklapka petrklapka added the old Used to help sort old issues on GH Projects which don't support the Created search term. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated old Used to help sort old issues on GH Projects which don't support the Created search term. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pgayvallet @majagrubic @TinaHeiligers @elasticmachine @petrklapka