Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate all visualize code in single directory #12675

Closed
thomasneirynck opened this issue Jul 6, 2017 · 2 comments
Closed

Consolidate all visualize code in single directory #12675

thomasneirynck opened this issue Jul 6, 2017 · 2 comments
Labels
chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jul 6, 2017 •
edited
Loading

The code for Visualize is currently very fragmented.

  • core_plugins (visualization utilties/implementations)

    • kbn_vislib_vis_types
    • markdown_vis
    • metrics
    • region_map
    • tagcloud
    • tile_map
    • region_map
    • table_vis
    • timelion
    • kibana/visualize (landing page of the app)

  • ui/public (utility-code)

    • vis
    • vislib
    • visualize
    • agg_configs
    • agg_response

Consider a more sensible reorganization.
e.g.:
- Move all reusable code to ui/public under single directory.
- Move all plugin code under single 'visualizations' directory in core_plugins
- retain visualize landing page under kibana/visualize
@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) chore release_note:enhancement labels Jul 6, 2017
@thomasneirynck thomasneirynck changed the title Consider consolidating all visualize code in single directory Consider consolidating all visualize code Jul 6, 2017
@thomasneirynck thomasneirynck mentioned this issue Jul 20, 2017
Closed
9 tasks
@thomasneirynck thomasneirynck mentioned this issue Aug 10, 2017
Merged
@thomasneirynck thomasneirynck changed the title Consider consolidating all visualize code Consolidate all visualize code in single directory Sep 27, 2017
@thomasneirynck
Copy link
Contributor Author

It's probably too late to do this for 6.0. It's a big reorganization, with some major internal impact.

@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 16, 2018
@timroes
Copy link
Contributor

timroes commented Nov 4, 2020

No longer relevant in the new Kibana Platform.

@timroes timroes closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timroes @thomasneirynck