[Fleet] Duplicate error coming when adding system integration with new agent policy

[juliaElastic]

Kibana version: 8.1

Describe the bug:

Bug introduced by #108456

When trying to add system integration with default incremental name (e.g. system-3 if there are 2 of them already existing) and new agent policy, the result is an error message saying that system-3 already exists.
This is because the new agent policy comes with system integration added by default, which uses the same incremental name as the default name on the create integration page.

Steps to reproduce:

1. Go to Add integration / System
2. click on Save integration (with default name and default new policy)
3. observe the error message saying an integration policy already exists with the same name

Expected behavior:
The error message shouldn't come and the Agent policy should be created with one system integration policy.

I think the right thing to do here is to have a check in the logic, not to create the agent policy with system monitoring, in case it is added for system integration.

Screenshots (if relevant):

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[juliaElastic]

@jen-huang what do you think about the severity of this bug? I'm not sure how frequently users are adding system integration specifically (with the default name). I'm thinking low or medium. I can fix this next week with a small effort I think.

[crowens]

I have a similar issue maybe, but seen on upgrade. I have an existing Agent Policy that I had before upgrading to 8.0. Now I see I have an upgrade available for the system integration in one of the policies, but trying to upgrade it fails with the same error seen above.

Not sure if it matters, but I have other integrations that already have upgraded system integrations:

[jen-huang]

@crowens Thank a lot for raising that! @juliaElastic The initial report is a bit of an edge case, but the one reported by Chris is far more concerning to me, could you look into that?

[juliaElastic]

@crowens @jen-huang the update issue reported by Chris is not related to this issue. The former happens in 8.0 and caused by having two integration policies named system-1 I think. The latter happens only in 8.1.

[amolnater-qasource]

Hi @juliaElastic
We have revalidated this issue on 8.1.0 BC-5 Kibana cloud environment and found it working fine.

• On adding system integration from Integrations tab to a new agent policy, no duplicate integration error is observed.
• Only one System integration is added the new Policy.

Build details:
VERSION: 8.1.0
BUILD: 50459
COMMIT: 23423b0

Screen Recording:

System.-.Integrations.-.Elastic.-.Google.Chrome.2022-03-03.12-21-36.mp4

Hence marking this as QA:Validated.

Thanks