Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] [Enhancement] Confirmation message should be displayed for new policy creation while adding integration. #125644

Open
ghost opened this issue Feb 15, 2022 · 5 comments
Assignees
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@ghost
Copy link

ghost commented Feb 15, 2022

Describe the bug
Successful notification message should displayed for new policy creation while adding the integration.

Issue observed at:

When we trying to add an integration with a duplicate name to a newly created policy on add integration page, We get error notification message There is already an integration policy with the same name: osquery_manager-1. However a new policy gets created at the background about which user is unaware, So when user again attempts to save the changes with updated integration name it now throws error for policy already existing. Therefore we would like to suggest to display a confirmation for policy creation for a better user experience at first attempt, clarifying how much action is covered.

Build Details

Version : v8.1.0-Snapshot
Commit :  168b8b47d25b32888138d1eb5d0d59264559ab6d
Build : 50283

Browser Details
This issue is occurring on all browsers.

Preconditions

  1. Kibana v8.1.0-Snapshot must be available.
  2. Policy having integration let say Osquery Manager with name osquery_manager-1 must be added.

Steps to Reproduce

  1. Navigate to Management -> Integrations - Osquery Manager
  2. Click on Add Osquery Manager button.
  3. Attempt to add integration with a duplicated integration name provided in the prerequisite.
  4. Provide policy name on New agent policy name under New hosts tab.
  5. Click on Save and continue button.
  6. Observe that error message There is already an integration policy with the same name: osquery_manager-1 is displayed but policy created (above integration not added) with no success notification message.

Actual Result

  1. Policy confirmation message not displayed.
  2. Only error message for duplicate integration name is displayed.

Expected Result
Success policy creation notification message should also be displayed with error notification message for better user experience.

What's Working

  • N/A

What's Not Working

  • N/A

Reference

  • We have separate message for import exception and import rule while importing rule of Rules tab under Security.

1 (1)

Screen Recording

Agent.policies.-.Fleet.-.Elastic.-.created.mp4
@ghost ghost added enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team labels Feb 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ghost
Copy link
Author

ghost commented Feb 15, 2022

@manishgupta-qasource : Please review the enhancement ticket.

@manishgupta-qasource
Copy link

Reviewed & assigned to @kpollich

@ghost ghost changed the title [Fleet] [Enhancement] Successful notification message should displayed for policy creation with error notification message of already an integration policy with the same name when add integration of same name with new agent policy for better visibility to the user [Fleet] [Enhancement] Confirmation message should be displayed for new policy creation while adding integration. Feb 15, 2022
@juliaElastic
Copy link
Contributor

We considered adding a toast on creating agent policy, but decided against it here: #121628 (comment)

I see your point about the error scenario. Maybe the agent policy should be rolled back if package policy creation fails. @joshdover WDYT?

@joshdover joshdover added Feature:Osquery Security Solution Osquery feature Team:Security Solution Platform Security Solution Platform Team Team:Fleet Team label for Observability Data Collection Fleet team and removed Team:Fleet Team label for Observability Data Collection Fleet team Feature:Osquery Security Solution Osquery feature Team:Security Solution Platform Security Solution Platform Team labels Feb 16, 2022
@joshdover
Copy link
Contributor

I see your point about the error scenario. Maybe the agent policy should be rolled back if package policy creation fails. @joshdover WDYT?

Could we validate both the agent policy and package policy before we start actually trying to create any objects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

4 participants