Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Refactor plugin cases "Add to new case" flyout show and hide logic out of timelines #124524

Closed
4 tasks
Tracked by #123183
academo opened this issue Feb 3, 2022 · 2 comments · Fixed by #125505
Closed
4 tasks
Tracked by #123183
Assignees
Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0

Comments

@academo
Copy link
Contributor

academo commented Feb 3, 2022

See epic #123183

The existing integration between alert timelines and cases consists of a series of hooks, contexts and callbacks that are not entirely reusable for other plugins and that require the timelines plugin to keep logic to track of open flyouts and to update cases to attach information to them.

To detach the "Add to new case" from timelines some code refactor is required in the display and hide flyout logic.

Currently the timelines plugin has the logic to open and close the cases flyout, this logic should be moved to the cases plugin control (see EPIC).

Acceptance criteria:

  • The timelines plugin doesn't handle opening and closing the cases flyout
  • Security and Observability are updated to create and handle the Cases context out of timeline scope.
  • Tests are updated in the timelines and cases plugin
  • Old code is kept for backwards compatibility (to be removed in following issues)

Existing setup:
image

Suggested setup:
image

Existing contexts setup:
image

Suggested contexts setup:
image

@academo academo added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.2.0 labels Feb 3, 2022
@academo academo self-assigned this Feb 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@academo academo changed the title [Cases] Refactor timelines plugin cases flyout logic [Cases] Refactor plugin cases flyout show and hide logic out of timelines Feb 11, 2022
@academo academo changed the title [Cases] Refactor plugin cases flyout show and hide logic out of timelines [Cases] Refactor plugin cases flyout show and hide logic out of timelines Feb 16, 2022
@academo academo changed the title [Cases] Refactor plugin cases flyout show and hide logic out of timelines [Cases] Refactor plugin cases "Add to new case" flyout show and hide logic out of timelines Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants