Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] Dashboard functional tests fail against 8.0 #123080

Closed
TinaHeiligers opened this issue Jan 14, 2022 · 8 comments
Closed

[7.17] Dashboard functional tests fail against 8.0 #123080

TinaHeiligers opened this issue Jan 14, 2022 · 8 comments
Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.17.0

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Jan 14, 2022

When testing 7.17 against Elasticsearch 8.0:

input controls tests

git checkout no-include_type_name
TEST_ES_BRANCH=8.0.0 node scripts/functional_tests_server --config test/functional/config.js
# in another terminal session run:
node scripts/functional_test_runner --config test/functional/config.js --grep="dashboard elements ciGroup10"

The following tests fail (requires unskipping https://github.com/elastic/kibana/blob/no-include_type_name/test/functional/apps/dashboard_elements/input_control_vis/input_control_range.ts#L21)

  • dashboard elements dashboard elements ciGroup10 input controls input control range should add filter with scripted field
  • dashboard elements dashboard elements ciGroup10 input controls input control range should add filter with price field

view mode tests

git checkout 7.17
TEST_ES_BRANCH=8.0.0 node scripts/functional_tests_server --config x-pack/test/functional/config.js
# in another terminal session run:
node scripts/functional_test_runner --config x-pack/test/functional/config.js --grep="Dashboard View Mode"

Screenshot:
Screen Shot 2022-01-14 at 13 00 10

The Dashboard View Mode tests are skipped here

dashboard mode Dashboard View Mode Dashboard viewer
- shows only the dashboard app link
- does not show the create dashboard button
- does not show the edit menu item
- Permalinks doesn't show create short-url button

Related #122962

@TinaHeiligers TinaHeiligers added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jan 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

ThomThomson commented Jan 14, 2022

I'm still looking into the Input controls failure, but I've figured out what is causing the View Mode tests to fail. The view mode tests are for a feature dashboard_only_user which has been deprecated for a long time, but was finally removed in 8.0.0. The reserved role was removed from Elasticsearch which is what is causing this failure. I am not sure if this would be considered a compatibility issue or not.

@lukeelmers
Copy link
Member

@ThomThomson The goal is to have read operations in Kibana continue to work wherever possible when it is running against an 8.0 cluster. However, as this was a breaking change on the Kibana side as well, I'm not sure if there's really anything we can do to fix it since we can't just backport a breaking change to 7.17.

This might fall under the category of things we just need to document ("dashboard only mode will stop working in 7.17 as soon as your ES cluster has been upgraded to 8.0")

cc @LeeDr

@TinaHeiligers TinaHeiligers changed the title [7.17] Dashboard input controls functional test fails against 8.0 [7.17] Dashboard functional tests fail against 8.0 Jan 14, 2022
@TinaHeiligers
Copy link
Contributor Author

@ThomThomson there's another failure that's dashboard related in CI group19.

Default CI Group #19 / dashboard feature controls dashboard feature controls security "before all" hook in "dashboard feature controls security"

@ThomThomson
Copy link
Contributor

@TinaHeiligers, this latest one looks like a maps problem. I was able to look into it a little bit with @thomasneirynck .This seems like it's related to this breaking change.

I couldn't find the tree mapping that was causing the failure, because it looks like it was removed in #122962, which is the branch that I'm running. Here are the differences in the mappings of that field that I can find.

7.17 used to look like:

"bounds" : {
  "type" : "geo_shape",
  "tree" : "quadtree"
},

the no-include_type_name branch looks like:

"bounds" : {
  "type" : "geo_shape"
},

while 8.0 looks like:

"bounds": {
  "dynamic": false,
  "properties": {}
},

I don't have the expertise to know which one should be used in this case, but clearly there is a problem when loading these mappings in - so at least you might know where to start!

@ThomThomson
Copy link
Contributor

Also for the controls failures, it looks like those tests were skipped in #113744 for 8.0 / Main for causing very similar failures to the ones we're running into here. I can't find any differences between 7.17 and 8.0.0 in the scripted fields which would cause this failure, but the element non-interactive error that causes the failure is due to an ES error. The last time the scripted fields were changed was here but both 8.0.0 and 7.17 have the same setup for the scripted field.

@LeeDr
Copy link

LeeDr commented Mar 8, 2022

I think the problem with the controls test is this deprecated method in the scripted field;

image

I have a fix here: #127230

@nreese
Copy link
Contributor

nreese commented Mar 23, 2023

Closing. no activity in over a year and 8.x has rollout has been ongoing for over a year +

@nreese nreese closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.17.0
Projects
None yet
Development

No branches or pull requests

7 participants