Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Warning in APM Integration Editor caused by invalid default duration #121640

Closed
sorenlouv opened this issue Dec 20, 2021 · 6 comments · Fixed by #124336
Closed

[APM] Warning in APM Integration Editor caused by invalid default duration #121640

sorenlouv opened this issue Dec 20, 2021 · 6 comments · Fixed by #124336
Assignees
Labels
bug Fixes for quality problems that affect the customer experience QA:Validated Issue has been validated by QA Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team v7.17.0 v8.0.0 v8.1.0

Comments

@sorenlouv
Copy link
Member

Under the Advanced Options in the APM Integration Editor we display a warning "Must be greater than 1ms" for the option "Maximum duration for reading an entire request".

image

The warning is displayed because the value (3600) doesn't contain a unit ("ms").

@sorenlouv sorenlouv added bug Fixes for quality problems that affect the customer experience v8.0.0 v7.17.0 labels Dec 20, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 20, 2021
@sorenlouv sorenlouv added the Team:APM All issues that need APM UI Team support label Dec 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 20, 2021
@sorenlouv sorenlouv changed the title [APM] [APM] Warning in APM Integration Editor Dec 20, 2021
@sorenlouv sorenlouv changed the title [APM] Warning in APM Integration Editor [APM] Warning in APM Integration Editor caused by invalid duration Dec 20, 2021
@sorenlouv sorenlouv changed the title [APM] Warning in APM Integration Editor caused by invalid duration [APM] Warning in APM Integration Editor caused by invalid default duration Dec 20, 2021
@cauemarcondes
Copy link
Contributor

We should either fix the default value to send the unit alongside the value, or on the UI add a default value for the unit as suggested by @ogupte . @simitt wdyt?

@simitt
Copy link
Contributor

simitt commented Jan 12, 2022

The default value actually contains a unit, it is set to 3600s (https://github.com/elastic/apm-server/blob/master/apmpackage/apm/manifest.yml#L109-L111).
What might be happening here is that this value is sent via the APM Server configs when the server starts up.

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@joshdover
Copy link
Contributor

Test instructions:

  • Launch 8.1.0 cluster on Cloud staging (I think you're going to need to wait for BC4)
  • Switch to managed APM by going to APM/Settings/Schema/Switch to Elastic Agent
  • Open the edit form on the APM integration policy on the Elastic Cloud agent policy
  • Expand the "Advanced options" accordion (not the one below the integration name, the one further down the page)
  • Verify that there is no validation warning on "Maximum duration for reading an entire request" and the value is set to 3600s

@amolnater-qasource
Copy link

Hi @joshdover
We have revalidated this issue on latest 8.1 BC-4 Kibana cloud environment and found it working fine.

  • There is no validation warning on "Maximum duration for reading an entire request" and the value is set to 3600s.

Build details:
VERSION: 8.1.0
BUILD: 50428
COMMIT: 015578b

Screenshot:
8

Hence marking this as QA:Validated.
Thanks

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience QA:Validated Issue has been validated by QA Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants