Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate architecture for client side cache sharing #121543

Closed
Tracked by #166068
flash1293 opened this issue Dec 17, 2021 · 5 comments
Closed
Tracked by #166068

Separate architecture for client side cache sharing #121543

flash1293 opened this issue Dec 17, 2021 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Search Sessions Feature:Search Querying infrastructure in Kibana Icebox impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@flash1293
Copy link
Contributor

Right now client side caching is piggy-backing on top of sessions. As client side caching needs to be shared across apps in some cases (especially going from dashboard to the visualization editor and back), sessions are shared between apps piggy-backing on embeddable state transfer.

Both of these things have been proven to be sub-optimal, so let's think about how this can be done in a more robust and extensible way.

Requirements:

  • It's possible to not lose client side request cache when moving between apps
  • It's possible to evict the client side cache in the right places

Reference #115515

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:AppServicesSv labels Dec 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@ThomThomson ThomThomson added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort labels Dec 17, 2021
@Dosant
Copy link
Contributor

Dosant commented Dec 17, 2021

Also there is currently a bug with session restoration due to client side cache: #106074 (comment)

@petrklapka petrklapka added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@petrklapka petrklapka added Feature:Search Querying infrastructure in Kibana Feature:Search Sessions labels Nov 21, 2022
@ThomThomson ThomThomson removed the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Apr 10, 2023
@ThomThomson
Copy link
Contributor

ThomThomson commented Apr 10, 2023

Removing the Presentation Team label from this one. Presentation team code is generally data-agnostic, and likely any caching solution would be built on the visualization, data view or core layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Search Sessions Feature:Search Querying infrastructure in Kibana Icebox impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

6 participants