Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Misleading reset functionality for Data Views #120609

Closed
MadameSheema opened this issue Dec 7, 2021 · 6 comments
Closed

[Security Solution] Misleading reset functionality for Data Views #120609

MadameSheema opened this issue Dec 7, 2021 · 6 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore

Comments

@MadameSheema
Copy link
Member

Describe the bug:

  • Misleading reset functionality for Data Views

Kibana/Elasticsearch Stack version:

Steps to reproduce:

  1. Navigate to a view where Data View can be edited
  2. Write a non-existing index pattern
  3. Click on reset icon

Current behavior:

  • The non-existing index pattern is not deleted

Expected behavior:

  • The non-existing index pattern is deleted

Screenshots (if relevant):
Overview - Kibana

@MadameSheema MadameSheema added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore labels Dec 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema
Copy link
Member Author

The save button functionality is misleading as well, since when you add a non-existing pattern and you click on the save button the dialog is closed making the impression the wrong index has been saved. Do we need to track this behaviour on a different ticket or can be part of this one?

@stephmilovic
Copy link
Contributor

The save button functionality is misleading as well, since when you add a non-existing pattern and you click on the save button the dialog is closed making the impression the wrong index has been saved. Do we need to track this behaviour on a different ticket or can be part of this one?

i will take care of both issues in the same PR

@stephmilovic
Copy link
Contributor

I actually think this is an Eui bug with EuiComboBox. look how it works on their demo page:
eui

The clear behavior does not clear invalid entries and i am not able to do so. i opened an issue with Eui: elastic/eui#5500

@MadameSheema I'm not sure if you want to close or wait until Eui closes their issue?

@MadameSheema
Copy link
Member Author

@stephmilovic I would suggest keeping it open in order to give visibility to our users. What do you think?

@stephmilovic
Copy link
Contributor

@MadameSheema I'd prefer to close it, it is exposed to the users through the EUI ticket elastic/eui#5498

Besides if user found this issue, they could read through the comments and see where EUI ticket is whether or not this ticket is closed

If you prefer to leave it open, can we remove me as assignee and remove it from the [Explore]( Security: Threat Hunting: Explore) board? otherwise it keeps showing up and does not really fit into any of our status categories

Screen Shot 2022-01-04 at 8 16 58 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore
Projects
None yet
Development

No branches or pull requests

3 participants