Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Suggestion: Visual cleanup of correlation textarea in Timeline #120302

Closed
Tracked by #120277
snide opened this issue Dec 2, 2021 · 5 comments
Closed
Tracked by #120277
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@snide
Copy link
Contributor

snide commented Dec 2, 2021

Shadows on toolbar under correlation are pretty heavy / unnecessary. Part of this looks like help text, while the other part is controls for the query. Suggestion would be to move the controls closer to the label, and leave the left text below as a typical form help text.

Likely can use some more definition from design. These are just suggestions. Short term though, that pretty ugly shadow probably be removed. This content could stand on it's own without the weight.

image

Resources

Figma design link

@snide snide added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Dec 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@michaelolo24 michaelolo24 added the Team:Threat Hunting:Investigations Security Solution Investigations Team label Dec 15, 2021
@MadameSheema MadameSheema added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed triage_needed labels Dec 15, 2021
@yiyangliu9286 yiyangliu9286 self-assigned this Feb 2, 2022
@MindyRS MindyRS added the Team:Threat Hunting Security Solution Threat Hunting Team label Feb 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@yiyangliu9286
Copy link

Please see the Figma design here.

Here is the screenshot of this UX/UI improvement view + list of UX/UI improvements have update to Timeline page under Correlation tab:

  • Updated the Refresh button colour as less primary here, ideally, there should be only one primary button in a page which in this case, would be "Attach to case" CTA.
  • Updated the "lock" button to better inline with the actual user intent (right now a single icon doesn't seem to be that intuitive). The question icon will explain this action further with the existing tooltip.
  • Update EQL form field design to use the EuiFormRow component.
    • Changed the EQL settings as a button and moved to the top right of this form field
    • Move Event Query Language (EQL) Overview to the helper text area
    • Question: Can we add any placeholders or query examples to the EQL query form filed or leave as blank in the empty state?

Screen Shot 2022-03-23 at 1 48 26 PM

@christineweng
Copy link
Contributor

I think we can close this ticket per #173015 @michaelolo24 ?

@PhilippeOberti
Copy link
Contributor

the UI for timeline has changed quite drastically over the last few recent months. We're now displaying a UI much closer to the Discover application, hence we can close this ticket!

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Development

No branches or pull requests

8 participants