Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Suggestion: Utilize dark toolbar for fixed position timeline #120295

Closed
Tracked by #120277
snide opened this issue Dec 2, 2021 · 4 comments
Closed
Tracked by #120277

[Security Solution] Suggestion: Utilize dark toolbar for fixed position timeline #120295

snide opened this issue Dec 2, 2021 · 4 comments
Assignees
@bfishel
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@snide
Copy link
Contributor

snide commented Dec 2, 2021

The current toolbar for timelines is the same color as the page content. Although it exists a layer above the content, it does not have an appropriate shadow. Suggestion would be to utilize EuiControlBar which has better affordance for this kind of content. Because the timeline currently opens as a "full page modal" the suggestion would be to utilize a not quite fixed height to better distinguish that it's a modal. If full screen real estate is required (likely) the suggestion would be to make this view it's own distinct page. Right now there are two heavy page DOMs being loaded without any cross-pollination.

This is likely a bigger ask, so the short term suggestion would be just to use a darker background for the timeline bar at the moment.

image
@snide snide added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Dec 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@snide snide mentioned this issue Dec 2, 2021
Open
25 tasks
@michaelolo24 michaelolo24 added the Team:Threat Hunting:Investigations Security Solution Investigations Team label Dec 15, 2021
@bfishel bfishel self-assigned this Feb 10, 2022
@MindyRS MindyRS added the Team:Threat Hunting Security Solution Threat Hunting Team label Feb 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@bfishel
Copy link

bfishel commented Mar 22, 2022

Mock here https://www.figma.com/file/UboMLC68n1UbgXopz3Us59/Issue-120295?node-id=3%3A16041
qq would white text work or is there a link color for dark backgrounds?

@PhilippeOberti
Copy link
Contributor

the UI for timeline has changed quite a bit over the last 3 years. There is now a shadow as seen in the screenshot below
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bfishel bfishel

Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@snide @MindyRS @elasticmachine @michaelolo24 @PhilippeOberti @bfishel