Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Add "adopt to future behaviour" or something like that in the warning Setting "xpack.reporting.roles" is deprecated #120263

Closed
bhavyarm opened this issue Dec 2, 2021 · 5 comments · Fixed by #121349
Closed

[Reporting] Add "adopt to future behaviour" or something like that in the warning Setting "xpack.reporting.roles" is deprecated #120263

bhavyarm opened this issue Dec 2, 2021 · 5 comments · Fixed by #121349
Assignees
@tsullivan
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Upgrade Assistant impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Dec 2, 2021

Kibana version: 7.16.0 Dec 2nd snapshot

Elasticsearch version: 7.16.0 Dec 2nd snapshot

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: The warning Setting "xpack.reporting.roles" is deprecated has how to fix

step 1 "Set "xpack.reporting.roles.enabled" to "false" in kibana.yml."

even if the user doesn't have that config setting in their kibana.yml.

Can we tell to the user - doing this will help you opt into a breaking future change and you are avoiding pain? :)

Like this es warning?

Screen Shot 2021-12-02 at 1 38 51 PM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Upgrade Assistant Team:AppServicesUx labels Dec 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Dec 2, 2021
@tsullivan
Copy link
Member

tsullivan commented Dec 3, 2021 •
edited
Loading

If we were to follow the same wording as the ES message, our message would say:

The default mechanism for Reporting privilege will work differently in future versions, which will affect the behavior of this cluster. Set [xpack.reporting.roles.enabled] to [false] to adopt the future behavior before upgrading.

@tsullivan
Copy link
Member

cc @mark54g @gchaps

@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Dec 6, 2021
@pheyos
Copy link
Member

pheyos commented Dec 14, 2021

Additional observation in the wording for this deprecation warning:

Step 2 says Remove "xpack.reporting.roles.allow" to "false" in kibana.yml, if present. - it's not clear if the user is supposed to remove this setting or update its value. Could we please update and clarify this for 7.17.0?

image

@tsullivan tsullivan self-assigned this Dec 15, 2021
@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:Reporting Services labels Dec 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@exalate-issue-sync exalate-issue-sync bot added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. impact:critical This issue should be addressed immediately due to a critical level of impact on the product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Dec 15, 2021
@tsullivan tsullivan mentioned this issue Dec 15, 2021
Merged
1 task
@exalate-issue-sync exalate-issue-sync bot changed the title Add "adopt to future behaviour" or something like that in the warning Setting "xpack.reporting.roles" is deprecated [Reporting] Add "adopt to future behaviour" or something like that in the warning Setting "xpack.reporting.roles" is deprecated Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsullivan tsullivan

Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Upgrade Assistant impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Reporting] Clarify deprecation changes of the roles settings tsullivan/kibana
4 participants
@tsullivan @pheyos @bhavyarm @elasticmachine