Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kibana-react] Possible memory leak in MountPointPortal #120254

Closed
Dosant opened this issue Dec 2, 2021 · 2 comments
Closed

[kibana-react] Possible memory leak in MountPointPortal #120254

Dosant opened this issue Dec 2, 2021 · 2 comments
Assignees
@Dosant
Labels
bug Fixes for quality problems that affect the customer experience Feature:kibana-react impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. performance

Comments

@Dosant
Copy link
Contributor

Dosant commented Dec 2, 2021

Kibana version: main (8.1) and before

Describe the bug:

Something in MountPointPortal is causing memory leak,
most likely not cleaned up ref.

Screen Shot 2021-12-02 at 19 07 14

Steps to reproduce:

  1. Open dashboard, navigate away, open again
  2. See that older dashboard objects stays in memory

image

(Please note, to completely fix the memory leak, some other issues like #120251 and #99473 should be fixed)
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience performance Feature:kibana-react Team:AppServicesUx labels Dec 2, 2021
@Dosant Dosant self-assigned this Dec 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@Dosant Dosant mentioned this issue Dec 2, 2021
Open
@Dosant Dosant changed the title [kibana-react] Memory leak in MountPointPortal [kibana-react] Possible memory leak in MountPointPortal Dec 2, 2021
@Dosant
Copy link
Contributor Author

Dosant commented Dec 3, 2021

this one seems to be expected. it doesn't keep growing, but just keeps the previous tree
https://github.com/facebook/react/issues/16087

@Dosant Dosant closed this as completed Dec 3, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Feb 1, 2022
@exalate-issue-sync exalate-issue-sync bot removed the loe:small Small Level of Effort label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
bug Fixes for quality problems that affect the customer experience Feature:kibana-react impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dosant @elasticmachine