Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support request-body comments #11973

Closed
PhaedrusTheGreek opened this issue May 23, 2017 · 3 comments · Fixed by #133852
Closed

Support request-body comments #11973

PhaedrusTheGreek opened this issue May 23, 2017 · 3 comments · Fixed by #133852
Assignees
@mibragimov
Labels
Feature:Console Dev Tools Console Feature Feature:Dev Tools high hanging fruit release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@PhaedrusTheGreek
Copy link
Contributor

Currently, the console does not allow comments in mid-body, but this feature would be highly useful.

screen shot 2017-05-23 at 11 52 46 am

It would also be great if you could collapse and comment.

screen shot 2017-05-23 at 11 53 51 am
@cjcenizal cjcenizal added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed :Management DO NOT USE labels Jun 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@cjcenizal cjcenizal mentioned this issue Jun 22, 2019
Closed
@cjcenizal cjcenizal mentioned this issue Jul 25, 2019
Closed
@cjcenizal cjcenizal mentioned this issue Jun 10, 2020
Closed
@cjcenizal
Copy link
Contributor

cjcenizal commented Jun 10, 2020 •
edited
Loading

Per @dgieselaar in #68770, we could also consider using // and /*...*/ (the latter for multiline comments) as these are supported by the JSON5 standard.

image

@cjcenizal cjcenizal mentioned this issue Aug 26, 2020
Closed
@cjcenizal cjcenizal mentioned this issue Sep 7, 2020
Closed
@cjcenizal
Copy link
Contributor

Per #64260, we'd also want to auto-indent comments when the auto-indent functionality is used. See that issue for an example of the desired behavior.

@mibragimov mibragimov self-assigned this May 26, 2022
@mibragimov mibragimov mentioned this issue May 30, 2022
Closed
@mibragimov mibragimov added WIP Work in progress and removed WIP Work in progress labels May 31, 2022
@cjcenizal cjcenizal mentioned this issue Jun 6, 2022
Closed
@mibragimov mibragimov mentioned this issue Jun 8, 2022
Merged
@mibragimov mibragimov removed the WIP Work in progress label Jun 8, 2022
@cjcenizal cjcenizal mentioned this issue Jul 8, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mibragimov mibragimov

Labels
Feature:Console Dev Tools Console Feature Feature:Dev Tools high hanging fruit release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
6 participants
@tylersmalley @cjcenizal @PhaedrusTheGreek @jloleysens @elasticmachine @mibragimov