Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make elasticsearch.maxSockets configurable #119612

Closed
mshustov opened this issue Nov 24, 2021 · 2 comments · Fixed by #126937
Closed

Make elasticsearch.maxSockets configurable #119612

mshustov opened this issue Nov 24, 2021 · 2 comments · Fixed by #126937
Assignees
@gsoldevila
Labels
bug Fixes for quality problems that affect the customer experience Feature:elasticsearch good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort performance Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

You can find the full discussion in #112756
TLDR: Kibana since v7.16 configures http.Agent of the elasticsearch client with maxSockets: Infinity to provide compatibility with the legacy elasticsearch client. In the case of high load, it might lead to growing memory consumption, which is never released later.
We can start with making the agent.maxSockets property configurable via kibana.yml to provide a way to deal with growing memory usage due to too many open sockets.
The problem can affect users starting from v7.16, shouldn't we consider backporting this change to v7.16?
@mshustov mshustov added bug Fixes for quality problems that affect the customer experience Feature:elasticsearch Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc performance labels Nov 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@mshustov mshustov mentioned this issue Nov 24, 2021
Closed
@lukeelmers lukeelmers added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 30, 2021
@lukeelmers
Copy link
Member

We'll want to add this setting to the cloud allowlist as well

@lukeelmers lukeelmers added the good first issue low hanging fruit label Feb 22, 2022
@gsoldevila gsoldevila mentioned this issue Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsoldevila gsoldevila

Labels
bug Fixes for quality problems that affect the customer experience Feature:elasticsearch good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort performance Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow customizing ES client maxSockets gsoldevila/kibana
4 participants
@lukeelmers @mshustov @elasticmachine @gsoldevila