Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search] remove data_enhanced #119321

Closed
5 tasks
ppisljar opened this issue Nov 22, 2021 · 6 comments · Fixed by #122075
Closed
5 tasks

[data.search] remove data_enhanced #119321

ppisljar opened this issue Nov 22, 2021 · 6 comments · Fixed by #122075
Assignees
Labels
Feature:Search Querying infrastructure in Kibana impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:medium Medium Level of Effort

Comments

@ppisljar
Copy link
Member

  • move search session configuration schema into data plugin
  • move search session management ui into data_search_session_management plugin
  • move search session indicator into data plugin
  • move search session saved object into data plugin
  • move search sessions (with routes) into data plugin
@ppisljar ppisljar added Feature:Search Querying infrastructure in Kibana Team:AppServicesSv labels Nov 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@exalate-issue-sync exalate-issue-sync bot changed the title [data.search] move data_enhanced into data [data.search] remove data_enhanced Nov 22, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Nov 22, 2021
@Dosant
Copy link
Contributor

Dosant commented Nov 22, 2021

This is duplicate of #92802

@Dosant
Copy link
Contributor

Dosant commented Dec 23, 2021

Started working on this:
When moving data_enhanced code into data plugin we need to make data plugin optionally depend on taskManager and security. There is no issues with taskManager, but there are cycles with security.:

  • data -> security -> data. Security only uses dataViews, so can depend on dataViews directly.
  • data -> security -> home - > data . Same home only uses dataViews, so can depend on dataViews directly.
  • data -> security -> home -> customIntegrations -> presentationUtils -> data. I think we can break up customIntegrations -> presentationUtils. Break customIntegrations -> presentationUtil dependency  #121951

@Dosant
Copy link
Contributor

Dosant commented Jan 6, 2022

The pr that remove data_enhanced is here: #122075

It is blocked by flaky ci, the failure reason is unclear.
I isolated the flakiness here: #121955
It appears after commit that add security as optional dependency of data plugin

@Dosant
Copy link
Contributor

Dosant commented Jan 25, 2022

Summed up a blocker in #123720

@Dosant Dosant removed the blocked label Mar 31, 2022
@Dosant Dosant self-assigned this Mar 31, 2022
@exalate-issue-sync exalate-issue-sync bot added loe:large Large Level of Effort loe:medium Medium Level of Effort and removed loe:medium Medium Level of Effort loe:large Large Level of Effort labels Apr 4, 2022
@Dosant
Copy link
Contributor

Dosant commented Apr 7, 2022

WIP in #122075, currently blocked by #121951 due to tsconfig refs circular dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:medium Medium Level of Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants