Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Make responses in fleet endpoints consistent #119182

Closed
Tracked by #123150
criamico opened this issue Nov 19, 2021 · 3 comments · Fixed by #119494
Closed
Tracked by #123150

[Fleet] Make responses in fleet endpoints consistent #119182

criamico opened this issue Nov 19, 2021 · 3 comments · Fixed by #119494
Assignees
@juliaElastic
Labels
Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0

Comments

@criamico
Copy link
Contributor

criamico commented Nov 19, 2021 •
edited
Loading

Audit Fleet APIs and make the response body consistent, as at the moment the body returns different values (comment)

  • /api/fleet/agent_policies returns items[] ,
  • /api/fleet/enrollment-api-keys returns item[]- list[],
  • /api/fleet/agents returns list[]

Check the openapi docs: https://petstore.swagger.io/?url=https://raw.githubusercontent.com/elastic/kibana/master/x-pack/plugins/fleet/common/openapi/bundled.json
@criamico criamico added v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic juliaElastic self-assigned this Nov 23, 2021
@juliaElastic
Copy link
Contributor

I found that enrollment-api-keys returns list[] parameter, not item[]

@juliaElastic juliaElastic mentioned this issue Nov 23, 2021
Merged
2 tasks
@criamico
Copy link
Contributor Author

criamico commented Dec 1, 2021 •
edited
Loading

I checked all the get requests and found other discrepancies:

  • /enrollment-api-keys/{keyId} returns item[] APIs the return a single record use item
  • /epm/packages/{pkgkey} returns response[]

EDIT: moving this comment to the main ticket

@joshdover joshdover mentioned this issue Jan 17, 2022
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliaElastic juliaElastic

Labels
Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Make API responses consistent juliaElastic/kibana
3 participants
@elasticmachine @criamico @juliaElastic