Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search] Make execution context required #118760

Closed
11 tasks
lukasolson opened this issue Nov 16, 2021 · 2 comments
Closed
11 tasks

[data.search] Make execution context required #118760

lukasolson opened this issue Nov 16, 2021 · 2 comments
Labels
Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort NeededFor:Core

Comments

@lukasolson
Copy link
Member

Related to #101587.

Currently, when calling data.search, it accepts an options parameter that currently includes a number of things as well as the following:

export interface ISearchOptions {
  // ...
  executionContext?: KibanaExecutionContext;
}

We would like to make executionContext a required parameter so that queries can be traced back to their origins. Since both expressions (esaggs and esdsl) and search source call data.search internally, we need to update these interfaces to also require execution context.

The following usages need to be updated to pass in execution context:

  • Search source (which calls data.search internally)
    • Search examples app
    • Terms agg post flight request
    • Maps app
    • Security Solution Fleet Osquery
  • EQL search
  • ES search (_search)
  • ES search (_async_search)
  • Data visualizer
  • Infra data search
  • Timeline search

This is a just a preliminary search, there may be other places we need to add this.

/cc @mshustov

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana NeededFor:Core and removed NeededFor:AppServices labels Nov 16, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 19, 2021
@lukasolson lukasolson added Team:AppServicesSv and removed needs-team Issues missing a team label labels Nov 19, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Nov 22, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Dec 13, 2021
@lizozom
Copy link
Contributor

lizozom commented Mar 3, 2022

Following the merge of #124996, most of the context is specified on the top most level by using the core ExecutionContextService. The request specific context is used only for overrides where necessary, so I don't believe it should be mandatory.

I believe this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort NeededFor:Core
Projects
None yet
Development

No branches or pull requests

3 participants