Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Adds dimension name to datatable column meta information #118516

Closed
Tracked by #75030
stratoula opened this issue Nov 15, 2021 · 2 comments
Closed
Tracked by #75030

[Lens] Adds dimension name to datatable column meta information #118516

stratoula opened this issue Nov 15, 2021 · 2 comments
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@stratoula
Copy link
Contributor

stratoula commented Nov 15, 2021

Describe the feature:
Part of #78277

In order to support alerting on expressions a new adapter has been added to inspector, to which every function producing a render output type should log the received datatable decorated with information about dimensions.

We would like to do for Lens what already has been done for the visualize editor. (need to pass to the adapter the dimensions meta) Here is the corresponding PR #107265

This can be done as part of the unification of the expressions. The only tricky part must be the xy charts that use the multitable, something that we will discuss during the unification of the xy charts. #116736

@stratoula stratoula added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Nov 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula
Copy link
Contributor Author

With the unification of the renderers among visualize and Lens, this has been done. I am closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

2 participants