-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exploratory view] No loading state for metric type dropdown #115740
Comments
Pinging @elastic/uptime (Team:uptime) |
@shahzad31 I might have misunderstood the issue as I couldn't find testing instructions for it, so apologies in advance if I missed anything. I have, however, I tried to test this according to my understanding by reading this issue and I didn't see a loader on the metric selector dropdown. This is the |
Yes, it should shows loading at this point, i will verify this locally. |
@shahzad31 this was my bad, actually. I realized I needed to merge some changes from upstream before testing this one. That's why the other ones were okay but this one wasn't. Now it LGTM, thanks for pointing it out 😄 Here's a gif of the new test: Just one question I've had is:
EDIT: Created #117275 with an "Enhancement label" after talking to @shahzad31. |
relates to elastic/uptime#361
No loading state for metric type dropdown while index pattern is still loading
The text was updated successfully, but these errors were encountered: