Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exploratory view] No loading state for metric type dropdown #115740

Closed
shahzad31 opened this issue Oct 20, 2021 · 4 comments · Fixed by #115748
Closed

[Exploratory view] No loading state for metric type dropdown #115740

shahzad31 opened this issue Oct 20, 2021 · 4 comments · Fixed by #115748
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0

Comments

@shahzad31
Copy link
Contributor

relates to elastic/uptime#361

No loading state for metric type dropdown while index pattern is still loading

@shahzad31 shahzad31 added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@lucasfcosta
Copy link
Contributor

@shahzad31 I might have misunderstood the issue as I couldn't find testing instructions for it, so apologies in advance if I missed anything.

I have, however, I tried to test this according to my understanding by reading this issue and I didn't see a loader on the metric selector dropdown.

This is the gif with what I've tried to do so you can double check:

output

@shahzad31
Copy link
Contributor Author

@shahzad31 I might have misunderstood the issue as I couldn't find testing instructions for it, so apologies in advance if I missed anything.

I have, however, I tried to test this according to my understanding by reading this issue and I didn't see a loader on the metric selector dropdown.

This is the gif with what I've tried to do so you can double check:

output

Yes, it should shows loading at this point, i will verify this locally.

@lucasfcosta
Copy link
Contributor

lucasfcosta commented Nov 1, 2021

@shahzad31 this was my bad, actually. I realized I needed to merge some changes from upstream before testing this one. That's why the other ones were okay but this one wasn't. Now it LGTM, thanks for pointing it out 😄

Here's a gif of the new test:

metrics-loading

Just one question I've had is:

  • When loading the third metric series there, it seems like the second series also starts loading, is this expected?

EDIT: Created #117275 with an "Enhancement label" after talking to @shahzad31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants