-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New platform initial setup #11468
Merged
Merged
New platform initial setup #11468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimjoar
force-pushed
the
platform-setup-ts
branch
3 times, most recently
from
April 27, 2017 13:06
cf6e3f2
to
c87cb70
Compare
kimjoar
added
the
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
label
Apr 27, 2017
kimjoar
force-pushed
the
platform-setup-ts
branch
from
April 27, 2017 13:18
c87cb70
to
b67e308
Compare
The build setup is bad right now, and this needs a lint setup, better TS setup, etc. |
kimjoar
force-pushed
the
platform-setup-ts
branch
from
April 27, 2017 17:20
b67e308
to
bfb40ab
Compare
kimjoar
force-pushed
the
platform-setup-ts
branch
4 times, most recently
from
May 8, 2017 11:37
28a1683
to
482d281
Compare
I get an npm error when I try to build this with a fresh
|
kimjoar
force-pushed
the
platform-setup-ts
branch
3 times, most recently
from
May 23, 2017 10:02
e66673a
to
f5c4fce
Compare
kimjoar
force-pushed
the
platform-setup-ts
branch
2 times, most recently
from
May 27, 2017 11:58
14d44cc
to
be87628
Compare
kimjoar
force-pushed
the
platform-setup-ts
branch
3 times, most recently
from
June 19, 2017 18:23
983a7b9
to
bde2d48
Compare
kimjoar
force-pushed
the
platform-setup-ts
branch
from
June 20, 2017 06:58
f3803a1
to
ed57d48
Compare
This was merged into the |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial architecture for #9675, including quite a bit of example code.
(The actual code diff is +3k~ lines, but tests and snapshots adds quite a few lines)
For explanation on setup see
platform/README.md
in the PR.How files are required (can be a help when understanding the general flow):
Todos
(these are NOT the todos for this PR, but things I've thought about while building this)
headers
allowedclient.close
doesn't exist in the typings./packages
and let it evolve with the rest of the code base.scripts/platform.js
in there, just to have something.require
s in the codebase we need to remove. Some of them seem to be related todefault export
stuff.import()
instead ofrequire
for plugins? (It makes starting plugins async, which doesn't fit nicely with starting the http server now, so we might need toawait
or something like that)platform/plugins
./logger
we have a readme that explains how the logger works. There is an example for the [plugin system][./server/plugins/README.md].