query:queryString:options setting doesn't revert when deleted

[LeeDr]

Might be related to #4040

This works the same on 5.2.0 so it's not a regression since then.

Kibana version: 5.4.0

Elasticsearch version: 5.4.0

Server OS version: CentOS 7

Browser version: Chrome

Browser OS version: Windows 10

Original install method (e.g. download page, yum, from source, etc.): .rpm

Description of the problem including expected versus actual behavior:
if I set Advanced Settings query:queryString:options , run a query, go back and delete my setting (to set it back to the default), and then go back to Discover and search again, it still uses the setting I deleted.
Changing the search query clears it. See steps 8 and 9 below where the expected result is not correct.
So this seems like some kind of caching we do of the query until we change the search in the query bar?

Steps to reproduce:

1. In Advanced Settings set query:queryString:options to { "analyze_wildcard": true, "fuzziness": 2} and save
2. go to Dev Tools > Console and query GET .kibana/config/_search and you should see "query:queryString:options": """{ "analyze_wildcard": true, "fuzziness": 2}"""
3. go to Discover, select a time-based index, do a search, collapse the histogram with the arrow to get to the "spy panel"
4. click the Request button and see that the query string looks like

"query_string": {
            "analyze_wildcard": true,
            "fuzziness": 2,
            "query": "*"
          }

5. go back to Advanced Settings and click delete for your query:queryString:options setting
6. go back to Console and run the same query. Now I see;
   "query:queryString:options": null
7. go back to Discover DON'T change the search but just click the Search magnifying glass.
8. collapse the histogram and click the Request button. you still see the "fuzziness": 2 but shouldn't
9. Refresh the browser page and check again, you still see the "fuzziness": 2 but shouldn't
10. change the search in the query bar to anything and search again. Now the "fuzziness": 2 finally is cleared.

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Describe the feature:

[Bargs]

The issue is that the query (full dsl) is stored in the app state, so even if you refresh the same query is run again. This makes a fix problematic because we can't tell if the query was generated automatically by us, or if the user entered the query DSL into the query bar manually. If it was the latter, we don't want to reset it.

Eventually we can fix this in the process of working on #10789 because I'm thinking we'll store the query string in the app state instead of the DSL.

[lukasolson]

This has been resolved.