-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Rule details page should always use resolve API #114127
Comments
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
@jportner Does this line up with your understanding as well? |
Oh, yes you should just use I noticed in the linked PR you also mentioned:
The sharing saved objects dev guide includes a link to a script to generate staging data. However that only works for exportable objects. To simulate a |
Is this going to affect your telemetry @jportner? This change would mean all page loads for any rule detail page would cause a hit for the |
Yes, this is expected. Any "deep link" URL should result in a call to When we say that we don't want to over-use the So I think this PR is good to merge 👍 |
Thanks for clarifying @jportner! |
With this PR, we updated the rule details page to try to load the rule using the normal GET API and only try using the new resolve API when the GET returns a 404.
@dhurley14 identified a bug with this logic because in the case of an SO ID conflict, the GET API would not return a 404, instead it would just return a SO (possibly not the right one) and the conflict message would never show up.
We should update to always use resolve when loading the rule details page so conflicts can be identified appropriately.
The text was updated successfully, but these errors were encountered: