Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add cards for linking to file upload pages #113940

Closed
joshdover opened this issue Oct 5, 2021 · 0 comments · Fixed by #114934
Closed

[Fleet] Add cards for linking to file upload pages #113940

joshdover opened this issue Oct 5, 2021 · 0 comments · Fixed by #114934
Assignees
Labels
Feature:Unified Integrations Unified Integrations view feature Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0

Comments

@joshdover
Copy link
Contributor

joshdover commented Oct 5, 2021

We need to register a card for the File Upload UI, similar to how we added cards for the sample data sets in #113200.

Title: File upload
Url: /app/home#/tutorial_directory/fileDataViz
Eui icon type: addDataApp
Category: upload_file
Description: Upload your file, analyze its data, and optionally import the data into an Elasticsearch index.

This card should only be registered when the upload file UI is registered, which happens here:

home.addData.registerAddDataTab({
id: FILE_DATA_VIS_TAB_ID,
name: i18n.translate('xpack.dataVisualizer.file.embeddedTabTitle', {
defaultMessage: 'Upload file',
}),
component: FileDataVisualizerWrapper,
});

Proposed way to solve this:

  • Add customIntegrations to the optionalPlugins in x-pack/plugins/data_visualizer/kibana.json
  • Update x-pack/plugins/data_visualizer/server/plugin.ts to call plugins.customIntegrations.registerCustomIntegration when plugins contains both home and customIntegrations (this way we only register this card if the UI it links to is also present).
@joshdover joshdover changed the title @clintandrewhall Add cards for linking to file upload pages [Fleet] Add cards for linking to file upload pages Oct 5, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 5, 2021
@joshdover joshdover added Feature:Unified Integrations Unified Integrations view feature Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 and removed needs-team Issues missing a team label labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Unified Integrations Unified Integrations view feature Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants