Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] Review data views plugin / strategy for reducing bundle size #113922

Closed
Tracked by #166175
mattkime opened this issue Oct 5, 2021 · 5 comments
Closed
Tracked by #166175
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@mattkime
Copy link
Contributor

mattkime commented Oct 5, 2021

Follow up to #113497

We need to review our strategy for reducing the data plugin bundle size. The data view code was broken out into its own plugin which resulted in a 11k increase in total bundle size. The core team may have suggestions for better strategies.

part of #84788

@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 5, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 5, 2021
@mattkime
Copy link
Contributor Author

mattkime commented Oct 5, 2021

@spalger Should you be involved in this or someone else on your team? Should we do this async or sync? How much time should we dedicate to coming up with a strategy for data views? More or less than 2 hours?

@Dosant
Copy link
Contributor

Dosant commented Oct 6, 2021

The actual issue: #84788

just leaving a note, that we plan to address all the "Aggs" part of a bundle with using async registry pattern that we started working at: #65993

@spalger
Copy link
Contributor

spalger commented Oct 7, 2021

I'd be happy to be part of the process. I think we could talk about strategy in this issue, but I generally find it's a lot more efficient to do on a call. I wouldn't expect such a call to take more than 2 hours.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Oct 12, 2021
@petrklapka petrklapka added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Oct 23, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as completed Oct 23, 2023
@kertal kertal added the Icebox label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

6 participants