Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Improve add integration to add agent flow #112626

Closed
10 tasks done
jen-huang opened this issue Sep 21, 2021 · 5 comments · Fixed by #114830
Closed
10 tasks done

[Fleet] Improve add integration to add agent flow #112626

jen-huang opened this issue Sep 21, 2021 · 5 comments · Fixed by #114830
Assignees
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0

Comments

@jen-huang
Copy link
Contributor

jen-huang commented Sep 21, 2021

Implement improvements as per design spec - Option A: #110063 (comment)

Please amend this initial implementation task list as needed:

  • On Integrations > Policies tab ([Fleet] Make add agent action more obvious in integration policy table #112936):
    • Move Agents column to last column (right before Actions column)
    • When agent column count is 0, replace the add agent flyout CTA that is currently "0 (+)" UI with a full "(+) Add agent" button as per design
  • On Add integration screen (aka policy editor), change "Save" button to "Save and continue"
    • Double check with design whether this copy should be used for all permutations of the policy editor such as Edit integration, Upgrade integration, or just during Add integration
  • On adding an integration which is not in use by any agents, after user clicks "Save and continue", present a confirmation modal with two choices: "Add Elastic Agent to your hosts" (primary action) and "Add Elastic Agent later" (secondary action) before moving the user on
  • If the user chooses to Add Elastic Agent now, open the Add agent flyout immediately when they are redirected to Integrations > Polices page
  • If the user chooses to defer, and arrived from the integration view, show a tour tooltip anchored to the Add agent button of the integration policy they just created
  • If the user chooses to defer, and arrived from the policy view, show a tour tooltip anchored to the Add agent link at the top of the page
  • On single policy view, show "add agent" link when no agents are assigned to the policy (design here: [Integrations][Design] Make add agent step more obvious #110063 (comment))
@jen-huang jen-huang added enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 labels Sep 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@hop-dev
Copy link
Contributor

hop-dev commented Sep 30, 2021

Hi @dikshachauhan-qasource, there have been two of additions to the scope of this ticket (last two points in the description), we will want to add tests for these, let me know if you need me to clarify further 👍

@dikshachauhan-qasource
Copy link

Hi @hop-dev

Thanks for the updates. I have added the required test cases at link below.

Please let me know if any changes are required.

Thanks
QAS

cc @EricDavisX

@dikshachauhan-qasource
Copy link

Hi @EricDavisX

We have validated above feature testcases and executed them under following feature test run.

Link: 7.16 Ingest feature test plan

Please let us know if anything else is required.

Thanks
QAS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants