Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Proposal: invert dependency between osquery and infra plugins #112402

Closed
hop-dev opened this issue Sep 16, 2021 · 3 comments
Closed

[Fleet] Proposal: invert dependency between osquery and infra plugins #112402

hop-dev opened this issue Sep 16, 2021 · 3 comments
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@hop-dev
Copy link
Contributor

hop-dev commented Sep 16, 2021

Currently the infra plugin has a dependency on the osquery plugin. This is preventing the fleet plugin from using the infra plugin as a cyclical dependency is created by osquery depending on fleet. The dependency cycle looks like this:

fleet --required-> infra --optional-> osquery --optional-> fleet

There are a few options to solving this, @joshdover has looked at a lot of possibilities in this comment.

We are proposing inverting the ifra -> osquery dependency as there is already logic in infra for when osquery is not enabled meaning they already reasonably loosely coupled.

Josh says it best on how we would invert the dependency:

infra would need to expose an API like registerOsQueryActionComponent and have the osquery plugin call this on the infra plugin.
@hop-dev hop-dev added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 16, 2021
@hop-dev hop-dev self-assigned this Sep 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@hop-dev
Copy link
Contributor Author

hop-dev commented Sep 16, 2021

@elastic/logs-metrics-ui and @elastic/security-asset-management I believe you manage infra and osquery respectively?

@jen-huang jen-huang added the technical debt Improvement of the software architecture and operational architecture label Mar 1, 2022
@joshdover
Copy link
Contributor

Let's continue the discussion #126578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

4 participants