-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core.logging] Update ECS typings to 8.0.0 #112175
Comments
Pinging @elastic/kibana-core (Team:Core) |
I've been spending time over the last few days trying to ingest kibana logs (and audit logs) with filebeat and struggling with a few items. They'll probably be resolved in this issue but I'll mention them here anyway.
|
cc @elastic/kibana-security
Yes, these are added to ECS-JSON logs. Not sure what {
"client":{
"ip":"127.0.0.1"
},
"http":{
"request":{
"method":"GET",
"mime_type":null,
"referrer":"http://localhost:5601/login?next=%2Fbon%2F",
"headers":{
"connection":"keep-alive",
"sec-ch-ua":"\"Chromium\";v=\"94\", \"Google Chrome\";v=\"94\", \";Not A Brand\";v=\"99\"",
"dnt":"1",
"sec-ch-ua-mobile":"?0",
"user-agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36",
"sec-ch-ua-platform":"\"macOS\"",
"accept":"*/*",
"sec-fetch-site":"same-origin",
"sec-fetch-mode":"no-cors",
"sec-fetch-dest":"script",
"referer":"http://localhost:5601/login?next=%2Fbon%2F",
"accept-encoding":"gzip, deflate, br",
"accept-language":"en-GB,en;q=0.9,en-US;q=0.8,ru;q=0.7,de;q=0.6,fr;q=0.5",
"cookie":"[REDACTED]",
"x-forwarded-for":"127.0.0.1",
"x-forwarded-port":"59814",
"x-forwarded-proto":"http",
"x-forwarded-host":"localhost:5601",
"host":"localhost:5601",
"traceparent":"00-129c4dc90acf028fc277593883b5200f-0c20a773443c7de8-01",
"tracestate":"es=s:1",
"elastic-apm-traceparent":"00-129c4dc90acf028fc277593883b5200f-0c20a773443c7de8-01"
}
},
"response":{
"body":{
"bytes":36880
},
"status_code":200,
"headers":{
"etag":"\"740c15b82af97f593e63c68833ae7c68237c3ab4-/bon/9007199254740991/bundles/plugin/expressionRevealImage/1.0.0/-gzip\"",
"cache-control":"must-revalidate",
"content-type":"application/javascript; charset=utf-8",
"x-content-type-options":"nosniff",
"referrer-policy":"no-referrer-when-downgrade",
"kbn-name":"Mikhails-MBP",
"kbn-license-sig":"092c91df379ac95bfcefcf05c5937d788dbbd74fd785706669676462d66ad323",
"vary":"accept-encoding",
"content-encoding":"gzip"
},
"responseTime":25
}
},
"url":{
"path":"/9007199254740991/bundles/plugin/expressionRevealImage/1.0.0/expressionRevealImage.plugin.js",
"query":""
},
"user_agent":{
"original":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36"
},
"ecs":{
"version":"1.9.0"
},
"@timestamp":"2021-10-01T12:03:28.459+02:00",
"message":"GET /9007199254740991/bundles/plugin/expressionRevealImage/1.0.0/expressionRevealImage.plugin.js 200 25ms - 36.0KB",
"log":{
"level":"DEBUG",
"logger":"http.server.response"
},
"process":{
"pid":86350
}
}
Would you mind creating an issue in beats repo and tag the Kibana team? |
@LeeDr Alternatively you could post a note to the beats issue that's tracking the 8.0 upgrade of the kibana filebeat module: elastic/beats#24136 |
In Core, we maintain a complete set of typings for ECS to enforce that any
LogMeta
added by plugins is ECS-compliant:kibana/packages/kbn-logging/src/ecs/index.ts
Lines 57 to 97 in 12b245c
ECS is working on finalizing their list of breaking changes for 8.0. We will need to update our types accordingly.
Note that we are also currently on ECS 1.9.0, so we'll also need to go through and make sure we've included any updates from 1.10 and 1.11:
(Someday, it would be nice to contribute to ECS by adding a generator for TypeScript, which would make this process a bit easier)
The text was updated successfully, but these errors were encountered: