Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Assistant] Support "success" state on overview page #110737

Closed
alisonelizabeth opened this issue Aug 31, 2021 · 7 comments
Closed

[Upgrade Assistant] Support "success" state on overview page #110737

alisonelizabeth opened this issue Aug 31, 2021 · 7 comments
Labels
enhancement New value added to drive a business result Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@alisonelizabeth
Copy link
Contributor

The "Overview" page in Upgrade Assistant currently displays a list of steps using the EuiSteps component, all of which hard-code the state to "incomplete".

We should be able to determine whether each step is complete and update the UI accordingly with the following logic:

  • Back up step is completed on Cloud when there are snapshots
  • Reindex system indices will be completed when they’ve all been reindexed
  • Fix issues step is completed when there are no critical warnings for ES or Kibana
  • Fix logs step is completed when there are no logs since the last checkpoint

As part of this work, we should also update the UI when a user has 0 critical deprecations.

Proposed design:
Screen Shot 2021-08-31 at 7 54 24 PM

@alisonelizabeth alisonelizabeth added enhancement New value added to drive a business result Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant labels Aug 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@cjcenizal
Copy link
Contributor

cjcenizal commented Sep 1, 2021

I noticed that the es_stats.tsx and kibana_stats.tsx components are fairly divergent in terms of their logic, which adds some maintenance friction given that they behave identically. As part of this scope, let's also extract out the common logic into a shared stats_panel.tsx component or something similar.

UPDATE: Addressing this in #111231

@cjcenizal
Copy link
Contributor

@dborodyansky Are we also planning on putting links inside of the panels? If so could we update the mockup?

image

@alisonelizabeth
Copy link
Contributor Author

Are we also planning on putting links inside of the panels?

I think we originally had links (but in the top right corner). I don't remember the specifics now, but at one point in a review it came up that it might be easier for the user if the entire panel was clickable, which is why we switched to using EuiCard. I don't have a strong opinion either way, but just wanted to share some background.

@sabarasaba
Copy link
Member

We indeed used to have a link on the top right corner. I think it looks much cleaner without any links, but the only problem I have with it is that the card is not treated as a link but as a div with an onClick event that navigates to a url. This means that when you hover the card you don't get a preview url from the browser and also breaks the cmd+click/ctrl+click to open the link in a new tab.

@dborodyansky
Copy link
Contributor

Moving "links inside cards" discussion to #111041

@alisonelizabeth
Copy link
Contributor Author

Addressed by #111243 and #111231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

5 participants