Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer rely on hashbangs for url routing #11015

Closed
psaiz opened this issue Apr 4, 2017 · 2 comments
Closed

No longer rely on hashbangs for url routing #11015

psaiz opened this issue Apr 4, 2017 · 2 comments
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@psaiz
Copy link

psaiz commented Apr 4, 2017

Describe the feature:

Kibana keeps in the url all the attributes needed to display a page. Most of those attributes are kept in the anchor (after the '#').
The issue that I have is when I setup apache with shibboleth to do the authentication. Since the anchor is kept on the client side, and it is not passed to the web server, after a successful authentication, the page loses the anchor, and it gets redirected to the default page.

It would be nice if the attributes were not kept in the anchor. That way, they will stay after a successful authentication

Steps to reproduce:

  1. Install kibana
  2. Configure kibana behind an apache reverse proxy with shibboleth
  3. Go to page https://myhost/app/kibana#/visualize/step/1?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-24h,mode:quick,to:now))
    (or any page with '#')

Errors in browser console (if relevant):

After a successful authentication, the page gets redirected to
https://myhost/app/kibana
(losing the anchor)

@epixa
Copy link
Contributor

epixa commented Apr 5, 2017

++ We should move to using the html5 URL history API instead of the current hashbang approach. This will help with things like proper logging as well.

The change is pretty drastic though, and it may be easiest to do once the new platform and new build tool are finished.

We have a bunch of issues that touch on this idea, but none that outright propose it as a standalone change.

@epixa epixa added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:enhancement labels Apr 5, 2017
@epixa epixa changed the title Kibana urls with '#' and shibboleth authentication No longer rely on hashbangs for url routing Apr 5, 2017
@epixa epixa added enhancement New value added to drive a business result and removed release_note:enhancement labels May 7, 2018
@epixa
Copy link
Contributor

epixa commented Aug 7, 2018

No clue how I missed this when I originally commented, but this is a duplicate of #6219

@epixa epixa closed this as completed Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants