Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] 'index: false' is ignored in fields when installing templates #109764

Closed
axw opened this issue Aug 24, 2021 · 4 comments · Fixed by #110234
Closed

[Fleet] 'index: false' is ignored in fields when installing templates #109764

axw opened this issue Aug 24, 2021 · 4 comments · Fixed by #110234
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@axw
Copy link
Member

axw commented Aug 24, 2021

Kibana version:

8.0.0-SNAPSHOT

Elasticsearch version:

8.0.0-SNAPSHOT

Describe the bug:

When Fleet installs the Elasticsearch index template for an integration, it ignores index: false on fields. I think it's because of this:

if (field.index) {
properties.index = field.index;
}

(That should probably check field.index is defined, rather than falsy?)

Steps to reproduce:

  1. Install an integration package with a field that specifies index: false
  2. Check the installed index template in Kibana, field is searchable

Expected behavior:

Field should not be searchable (not indexed).

@axw axw added bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:EPM)

@hop-dev
Copy link
Contributor

hop-dev commented Aug 26, 2021

Detailed steps to reproduce/test :

  • Synthetics has the field client.x509.public_key_exponent set not to index here
  • add the synthetics integration to a policy
  • GET /_index_template/synthetics-http
  • observe that client.x509.public_key_exponent does not have index : false or if fixed should look like:
"public_key_exponent" : {
  "index" : false,
  "type" : "long"
},

@axw
Copy link
Member Author

axw commented Aug 27, 2021

Thanks @hop-dev! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants