Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Remove hardcoded values for data streams #109104

Closed
sorenlouv opened this issue Aug 18, 2021 · 1 comment
Closed

[APM] Remove hardcoded values for data streams #109104

sorenlouv opened this issue Aug 18, 2021 · 1 comment
Assignees
Labels
apm:test-plan-7.16.0 apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.0.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Aug 18, 2021

Related: #88329

Data streams are currently hardcoded in:

// Add data stream indices to list of configured values
mergedConfig[
'apm_oss.transactionIndices'
] = `traces-apm*,${mergedConfig['apm_oss.transactionIndices']}`;
mergedConfig[
'apm_oss.spanIndices'
] = `traces-apm*,${mergedConfig['apm_oss.spanIndices']}`;
mergedConfig[
'apm_oss.errorIndices'
] = `logs-apm*,${mergedConfig['apm_oss.errorIndices']}`;
mergedConfig[
'apm_oss.metricsIndices'
] = `metrics-apm*,${mergedConfig['apm_oss.metricsIndices']}`;
mergedConfig[
'apm_oss.indexPattern'
] = `traces-apm*,logs-apm*,metrics-apm*,${mergedConfig['apm_oss.indexPattern']}`;

This should be removed to make it possible to specify data streams with name spaces

New defaults:

  • Transactions: traces-apm*, apm-*-transaction-*
@sorenlouv sorenlouv added [zube]: Inbox Team:APM All issues that need APM UI Team support v8.0.0 labels Aug 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-7.16.0 apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.0.0
Projects
None yet
Development

No branches or pull requests

4 participants