Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] Rule Details show 'Activated' text regardless of if Rule is active or disabled #108939

Closed
spong opened this issue Aug 17, 2021 · 6 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@spong
Copy link
Member

spong commented Aug 17, 2021

The Rule Details Activate switch show the text Activated regardless of if the Rule is active or disabled.

Activated:

Deactivated:

Source:

<RuleSwitch
id={rule?.id ?? '-1'}
isDisabled={
!isExistingRule ||
!canEditRuleWithActions(rule, hasActionsPrivileges) ||
!userHasPermissions(canUserCRUD) ||
(!hasMlPermissions && !rule?.enabled)
}
enabled={isExistingRule && (rule?.enabled ?? false)}
onChange={handleOnChangeEnabledRule}
/>
<EuiFlexItem>{i18n.ACTIVATED_RULE}</EuiFlexItem>

cc @elastic/security-design for intended copy/UX here. Should it switch to Deactivated, animate as Activating.../Deactivating... on state change, or is this text even necessary here?

@spong spong added bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0 labels Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@mdefazio
Copy link
Contributor

Deleted my previous comment...misread the suggestion in the issue 🙃 !

@peluja1012
Copy link
Contributor

PR where we decided the current behavior is here #94010 (comment)

@yiyangliu9286
Copy link

PR where we decided the current behavior is here #94010 (comment)

The conclusion that has been decided in #94010 as using Activated as the toggle label works based on the EuiSwitch guideline. There is an updated guideline PR specifically talks around when / how to apply label to EuiSwitch.

For fwiw, just an fyi, in the future there might be thinkings around keeping the label consistent in Stack Rules and Connectors table as part of the RAC Rules sharing component to update the label to Enabled instead of Activated... so just wanted to give an fyi for the future label consideration (but "Activated" can work right now).

This view is still a proposed WIP design 👇
Rule details page_ rule execution log

@spong
Copy link
Member Author

spong commented Sep 1, 2021

Thank you for the clarification @peluja1012 and @yiyangliu9286, and apologies for the noise here since this is as designed. Going to close this issue as we'll handle the potential update to Enabled as an output of the re-worked designs. Thanks for the heads up on that @yiyangliu9286! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

5 participants