Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align expressions renderMode with embeddables viewMode #108906

Closed
3 tasks
ppisljar opened this issue Aug 17, 2021 · 1 comment · Fixed by #110199
Closed
3 tasks

align expressions renderMode with embeddables viewMode #108906

ppisljar opened this issue Aug 17, 2021 · 1 comment · Fixed by #110199
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@ppisljar
Copy link
Member

there is a difference between embeddable viewMode and expressions renderMode and we should align them, thus:

  • we will add preview to embeddable viewModes
  • we will rename display expressions renderMode to view
  • we will remove noInteractivity expression renderMode in favour of noInteractivity flag (separate from renderMode)
@ppisljar ppisljar added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppServices labels Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Aug 17, 2021
@dokmic dokmic mentioned this issue Aug 26, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Expressions] Align renderMode with the embeddable viewMode dokmic/kibana
2 participants
@ppisljar @elasticmachine