Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability RAC] Implement workflow status filters UX for observability alerts table #107629

Closed
6 of 7 tasks
mgiota opened this issue Aug 4, 2021 · 4 comments · Fixed by #108215
Closed
6 of 7 tasks
Assignees
Labels
Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete

Comments

@mgiota
Copy link
Contributor

mgiota commented Aug 4, 2021

📝 Summary

Relates to #106585
Alerts Table Filter Options in Observability Alerts page should be updated according to following:

✔️ Acceptance criteria

  • Move workflow status button group to left side above trend chart and change to sm, primary EuiButtonGroup ([RAC] Enable workflow status filtering #108215)
  • Workflow button group statuses should be Open, Acknowledged, Closed ([RAC] Enable workflow status filtering #108215)
    • image
  • Move Last updated... to same line as button group and right align
  • Include Alerts total count (filtered by KQL bar + Workflow statuses) before DataGrid modifier buttons
  • Remove 'Showing X alerts | Selected alerts 0'
  • 'Take action' bulk action button renamed to 'X alerts selected'
  • Remove 'Take action' bulk action button and 'Select all' button from default view. These should show only when a user selects a row (see above mockup for 'Filter option updated states')
    • None selected, Some selected, All selected
      image

Note: Strikethrough options have already been implemented by the security team

Dependencies

@mgiota mgiota added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete labels Aug 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@jasonrhodes jasonrhodes changed the title [Observability RAC] Alerts Table Filter Options Updates [Observability RAC] Implement workflow status filters UX for observability alerts table Aug 9, 2021
@afgomez
Copy link
Contributor

afgomez commented Aug 11, 2021

  • Move Last updated... to same line as button group and right align

This item is not as straightforward as it seems. Both the Last update label and value live within the TGrid component. It would need a way to expose this value to consumers.

@elastic/observability-security-team (or other) with whom I can speak about this to create a reasonable API?

@jasonrhodes
Copy link
Member

Thanks for calling that out, @afgomez -- I think this would be @michaelolo24 / @XavierM and @elastic/security-threat-hunting

I'm fine if we punt on that change for right now and focus on getting the button group working.

@jasonrhodes
Copy link
Member

Oh I see you've separated them in your PR, perfect. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants