Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default styles for CodeEditor #107590

Closed
ryankeairns opened this issue Aug 3, 2021 · 1 comment · Fixed by #107930
Closed

Add default styles for CodeEditor #107590

ryankeairns opened this issue Aug 3, 2021 · 1 comment · Fixed by #107930
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@ryankeairns
Copy link
Contributor

We currently use in a lot of of places that CodeEditor is already in place custom options and basically every place looks slightly different (we even don't have a shared fontSize between those instance). Since we're now heavily start using it in more places, could Design please take a pass on that, and make sure that the CodeEditor component itself has reasonable default stylings and not every consumer does an (unaligned) styling in their application?

Originally posted by @timroes in #106931 (comment)
@ryankeairns ryankeairns added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Aug 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@ryankeairns ryankeairns mentioned this issue Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add monaco default style options ryankeairns/kibana
2 participants
@ryankeairns @elasticmachine