Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate actions JSON editor to use the monaco-based editor #107203

Closed
mikecote opened this issue Jul 29, 2021 · 3 comments · Fixed by #122734
Closed

Migrate actions JSON editor to use the monaco-based editor #107203

mikecote opened this issue Jul 29, 2021 · 3 comments · Fixed by #122734
Assignees
@JiaweiWu
Labels
chore estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Alerting/RuleActions Issues related to the Actions attached to Rules on the Alerting Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

x-pack/plugins/triggers_actions_ui/public/application/components/json_editor_with_message_variables.tsx uses the deprecated EuiCodeEditor component, which is slated for removal in the 7.16 timeframe.

Deprecation notice: elastic/eui#3807
Meta issue: #106931
@mikecote mikecote added chore Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RuleActions Issues related to the Actions attached to Rules on the Alerting Framework labels Jul 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote mentioned this issue Jul 29, 2021
Open
42 tasks
@mikecote
Copy link
Contributor Author

mikecote commented Aug 4, 2021

Worth considering #104733

@mikecote mikecote mentioned this issue Aug 4, 2021
Open
@gmmorris
Copy link
Contributor

I have spoken to @chandlerprall and it sounds like we can defer this work until after our 8.0 breaking change deadline is behind us.
@mikecote will reprioritize this issue for soon after our 8.0 priorities.

@gmmorris gmmorris added the loe:needs-research This issue requires some research before it can be worked on or estimated label Aug 11, 2021
@gmmorris gmmorris added the estimate:needs-research Estimated as too large and requires research to break down into workable issues label Aug 18, 2021
@gmmorris gmmorris removed the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 2, 2021
@JiaweiWu JiaweiWu mentioned this issue Jan 12, 2022
Merged
3 tasks
@gmmorris gmmorris moved this from In Progress to In Review in AppEx: ResponseOps - Rules & Alerts Management Jan 25, 2022
Repository owner moved this from In Review to Done in AppEx: ResponseOps - Rules & Alerts Management Jan 26, 2022
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiaweiWu JiaweiWu

Labels
chore estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Alerting/RuleActions Issues related to the Actions attached to Rules on the Alerting Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ResponseOps] Migrate EUI CodeEditor in the triggers actions ui to use the monaco based editor
5 participants
@gmmorris @kobelb @mikecote @elasticmachine @JiaweiWu