Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Suffix field format leaks to index pattern management #106839

Closed
Dosant opened this issue Jul 27, 2021 · 4 comments · Fixed by #107139
Closed

[Lens] Suffix field format leaks to index pattern management #106839

Dosant opened this issue Jul 27, 2021 · 4 comments · Fixed by #107139
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:FieldFormatters Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@Dosant
Copy link
Contributor

Dosant commented Jul 27, 2021

Version: master and since suffix formatter was introduced in 7.11 (#82852)

After running lens app/embeddable and then navigating to field format editor in index pattern management "suffix" option is available:

Screen Shot 2021-07-27 at 11 54 57

I assume this isn't expected and this formatter shouldn't be exposed in management.

We are introducing a hidden flag on-field format definition which should help with this: #106755

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens Feature:FieldFormatters labels Jul 27, 2021
@Dosant Dosant self-assigned this Jul 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ghudgins ghudgins added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jul 27, 2021
@dej611
Copy link
Contributor

dej611 commented Jul 28, 2021

Do you have more information on how to reproduce this bug? I've tried several routes but I couldn't reproduce it yet.

@Dosant
Copy link
Contributor Author

Dosant commented Jul 28, 2021

@dej611, sure these are my steps:

  1. go to index pattern management,
  2. try to add a field format on any number field. See there is no "suffix" option in the format dropdown
  3. go to lens
  4. Without a page reload navigate back to index pattern management.
  5. Try to add a field format on any number field. See there IS a"suffix" option in the format dropdown

I think #106755 provides an easy solution for this, we will be able to mark formats as "hidden". I will put up a pr when this is merged and will check if it works as expected for this bug

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:FieldFormatters Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants