Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizations are missing Dark Theme styles #10322

Closed
cjcenizal opened this issue Feb 13, 2017 · 6 comments
Closed

Visualizations are missing Dark Theme styles #10322

cjcenizal opened this issue Feb 13, 2017 · 6 comments
Labels
enhancement New value added to drive a business result Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Feb 13, 2017

image

The main visualization color (e.g. green in the screenshot) should probably fade into the background color, instead of into white.

CC @thomasneirynck @ppisljar

@cjcenizal cjcenizal added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience labels Feb 13, 2017
@ppisljar
Copy link
Member

its not actually fading color to bg ... this are colors defined in color schema (which can be selected or even custom colors can be defined).

this is consistent with how every other vislib chart is working.

i agree we should provide different schemas for dark theme, but thats something to do in every visualization in kibana. some old discussion for reference: #1362

do you want to mark this as enhancement and change title and description to track this for all charts ?

@cjcenizal cjcenizal changed the title Heat map is missing Dark Theme styles Visualizations are missing Dark Theme styles Feb 14, 2017
@cjcenizal
Copy link
Contributor Author

@ppisljar Thanks man! I was actually describing how it should behave, not how it currently behaves.

Good to know that this applies to all charts. I've updated the title and description to reflect the broader scope. Let's keep this marked as a bug. It's a UI bug, but it's still a bug, and from a UI perspective I think it's important we fix it.

@tbragin tbragin added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. release_note:enhancement and removed bug Fixes for quality problems that affect the customer experience labels Feb 28, 2017
@snide
Copy link
Contributor

snide commented Aug 15, 2018

Closing this older issue out since we likely won't fix it in our currently charts. We do have plans to add a pallette service to EUI (its on our roadmap) and will be backed into the new charting library.

@snide snide closed this as completed Aug 15, 2018
@snide
Copy link
Contributor

snide commented Aug 15, 2018

Reopening after talking with @cjcenizal. I'll reference this in an EUI ticket.

@snide snide reopened this Aug 15, 2018
@snide
Copy link
Contributor

snide commented Aug 15, 2018

A similar discussion about pallette selection #11027

@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 16, 2018
@markov00 markov00 added enhancement New value added to drive a business result and removed release_note:enhancement labels Feb 2, 2023
@stratoula
Copy link
Contributor

I think that with the EUI palettes used in Lens this is not a problem anymore. We also plan to take this under consideration on color by terms project in Lens so I am closing this as we dont plan to do more enhancements on our legacy palettes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

7 participants