-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualizations are missing Dark Theme styles #10322
Comments
its not actually fading color to bg ... this are colors defined in color schema (which can be selected or even custom colors can be defined). this is consistent with how every other vislib chart is working. i agree we should provide different schemas for dark theme, but thats something to do in every visualization in kibana. some old discussion for reference: #1362 do you want to mark this as enhancement and change title and description to track this for all charts ? |
@ppisljar Thanks man! I was actually describing how it should behave, not how it currently behaves. Good to know that this applies to all charts. I've updated the title and description to reflect the broader scope. Let's keep this marked as a bug. It's a UI bug, but it's still a bug, and from a UI perspective I think it's important we fix it. |
Closing this older issue out since we likely won't fix it in our currently charts. We do have plans to add a pallette service to EUI (its on our roadmap) and will be backed into the new charting library. |
Reopening after talking with @cjcenizal. I'll reference this in an EUI ticket. |
A similar discussion about pallette selection #11027 |
I think that with the EUI palettes used in Lens this is not a problem anymore. We also plan to take this under consideration on color by terms project in Lens so I am closing this as we dont plan to do more enhancements on our legacy palettes |
The main visualization color (e.g. green in the screenshot) should probably fade into the background color, instead of into white.
CC @thomasneirynck @ppisljar
The text was updated successfully, but these errors were encountered: