Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeddable migration and Persistable State updates #103102

Closed
3 tasks
stacey-gammon opened this issue Jun 23, 2021 · 2 comments
Closed
3 tasks

Embeddable migration and Persistable State updates #103102

stacey-gammon opened this issue Jun 23, 2021 · 2 comments
Labels
impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort

Comments

@stacey-gammon
Copy link
Contributor

stacey-gammon commented Jun 23, 2021

The current implementation relies on the persistor of embeddable state to use getMigration (on PersistableStateDefinition) and getMigrationVersions (from EmbeddableFactory I believe) together to run migrations correctly (otherwise the plugin author won't know what version number to pass into the getMigration function).

The getMigration and getAllMigrationVersions should be replaced with a single getMigrations function on PersistableStateService interfaces that returns an object with the versions mapped to the functions. This will make it easier for consumers.

Additional persistable state items tracked in other issues:

I'm adding this as critical impact because of the impact this will have on users of PersistableStateService. This change should result in improved upgrade stability, by making it less fragile to use in an incorrect manner.

@stacey-gammon stacey-gammon added Team:AppServices impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Jun 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added the loe:small Small Level of Effort label Jun 24, 2021
@ppisljar
Copy link
Member

ppisljar commented Jul 8, 2021

resolved by #103680

@ppisljar ppisljar closed this as completed Jul 8, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort
Projects
None yet
Development

No branches or pull requests

3 participants