Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Latency correlations: Move progress bar loader into the correlation results table and move the refresh option with it. #102984

Closed
formgeist opened this issue Jun 22, 2021 · 7 comments
Assignees
Labels
apm:correlations enhancement New value added to drive a business result :ml Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

Summary

Moved over from meta issue: #102499

It'd be preferable to have the loader sit in the context of the table of correlations results and give the user to refresh near the table as well.

image

@formgeist formgeist added Team:APM All issues that need APM UI Team support enhancement New value added to drive a business result :ml apm:correlations labels Jun 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Jun 23, 2021

I don't think this sort numerical progression loading indicator is available out of the box for EUI basic table (looks like it's only infinite loading to indicate whether table is loading or not). Do we have something like this already implemented inside APM?

@formgeist
Copy link
Contributor Author

@qn895 I think we're using the infinite loader in our tables too. Does it matter to the user if the loader is numerical progression or inifite? They can interact with the table either way.

@sophiec20
Copy link
Contributor

I think the numerical progression is useful for the user. Calculations could take several minutes on reasonably sized data. The user should understand if they are part way through the analysis or nearing its completion. Suggest we leave with progression loading indicator for 7.14.

@formgeist
Copy link
Contributor Author

OK, let's keep it as is for now

@formgeist
Copy link
Contributor Author

Closing as we'll keep the progressive loader over the continuous loading indicator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:correlations enhancement New value added to drive a business result :ml Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

5 participants