-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] Implement context propagation for Kibana entities #102629
Comments
Pinging @elastic/kibana-core (Team:Core) |
I think that the merge of #124996 changes the second phase of this issue. I think we could create issues for solutions to start working on it at their own pace. What do you think? |
I wouldn't say these things are mutually exclusive, but rather they complement each other. We can ask Solution teams to instrument their code with |
Yea, I think so. Just need to align with my team before taking that task. I'll come back to you with an update, likely at the beginning of next week. |
Use the service introduced in #102626 to instrument Kibana code with runtime context metadata:
Phase I:
Phase II (TBD dates)
Propagate execution context from Canvas #126797Propagate execution context from Observability #126798Propagate execution context from Enterprise Search #126801Acceptance Criteria
Nested context
#102626 will add the ability to create nested / linked contexts. It can be used to compose execution context relationships across different apps.
Application service context --> Dashboard context --> Visualization context.
Integration with embeddable
As discussed with @ppisljar we need to extend
EmbeddableInput
interface withexecutionContext
kibana/src/plugins/embeddable/common/types.ts
Line 16 in 859caf2
In the turn, every application creating an embeddable container will create application-specific
execution context
object and provide it as a part of input when callingupdateInput
kibana/src/plugins/embeddable/public/lib/embeddables/embeddable.tsx
Line 152 in 859caf2
How to test
automatic testing
It's better to automate the check to prevent unexpected failures in the future. You can use these files as a referenced implementation of the functional tests.
for the client side code
for the server side code
manual testing
Steps to test the PR manually:
request.id: opaqueId
inelasticsearch response
andexecution_context
whenever it's setThe text was updated successfully, but these errors were encountered: